[lkml]   [2002]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC/CFT] cmd640 irqlocking fixes
>Martin this patch should do the job. It uses the correct pci_config_lock
>and it also adds the 2.4 probe safety checks for deciding which pci
>modes to use.

Hrm... pci_config_lock is specific to arch/i386 it seems (and is even
a static in 2.4.19rc3). That is no good as this isn't the only
driver to do config access from interrupts, so at least PPC is
broken in this regard.

Wouldn't it make sense to generalize it and implement it on all archs ?

(That is move extern declaration of it to linux/pci.h, definition to
drivers/pci/pci.c, and so on...)

I'd rather have a per-host lock, but on the other hand, the host bus
mecanism is still quite arch-specific, thus making difficult to use
a per-host lock in drivers, at least in 2.4


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:27    [W:0.126 / U:2.676 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site