Messages in this thread | | | From | Benjamin Herrenschmidt <> | Subject | Re: [RFC/CFT] cmd640 irqlocking fixes | Date | Thu, 25 Jul 2002 15:39:18 +0200 |
| |
>Martin this patch should do the job. It uses the correct pci_config_lock >and it also adds the 2.4 probe safety checks for deciding which pci >modes to use.
Hrm... pci_config_lock is specific to arch/i386 it seems (and is even a static in 2.4.19rc3). That is no good as this isn't the only driver to do config access from interrupts, so at least PPC is broken in this regard.
Wouldn't it make sense to generalize it and implement it on all archs ?
(That is move extern declaration of it to linux/pci.h, definition to drivers/pci/pci.c, and so on...)
I'd rather have a per-host lock, but on the other hand, the host bus mecanism is still quite arch-specific, thus making difficult to use a per-host lock in drivers, at least in 2.4
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |