lkml.org 
[lkml]   [2002]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] irqlock patch 2.5.27-H4

    On Wed, 24 Jul 2002, Ingo Molnar wrote:

    > the latest irqlock patch can be found at:
    >
    > http://redhat.com/~mingo/remove-irqlock-patches/remove-irqlock-2.5.27-H4
    >
    > Changes in -H4:
    >
    > - fix the cli()/sti() hack in ide/main.c, per Marcin Dalecki's
    > suggestion. [this leaves the tty layer as the only remaining subsystem
    > that still has cli()/sti() related hacks.]

    Hi Ingo,

    Marcin's suggestions will bring you nowhere.

    You should remove all these locking from ide_unregister_subdriver()
    because in 100% cases it is already called with ide_lock held.

    Also in ide subsystem ide-tape.c needs fixing, however it is already
    broken and proper locking fixing may be non-trivial task.

    Regards
    --
    Bartlomiej

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:0.023 / U:58.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site