lkml.org 
[lkml]   [2002]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: please DON'T run 2.5.27 with IDE!
    Jens Axboe wrote:

    >>>>My goal is to make sure that the QUEUE_FLAG_STOPPED has a valid value
    >>>>*inside* the q->request_fn call.
    >>>
    >>>So you want the queue_lock to protect the flags as well... I don't
    >>>really see the point of this.
    >>
    >>If driver corectly uses blk_start/stop_queue() it is not needed.
    >>Whole point of introducing this flag was not to take lock to check
    >>status of queue.
    >
    >
    > Right. The way it was meant to be used it how cpqarray and cciss does
    > it -- stopping queue in request_fn, restarting it from isr.

    Yes got it. Of course. But please note that:

    1. My suggestion doesn't change the checking case.

    2. What you describe is precisely what I would like to be able to
    do in my own "playground".



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:2.597 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site