lkml.org 
[lkml]   [2002]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] 2.5.27 smbiod
Date
Marcin Dalecki writes:

> Fix label at block end warning - don't write "assembler code".
...
> if (server->state != CONN_VALID)
> - goto out;
> + return;
...
> -
> -out:
> }


Assembler? No, that would be Pascal. Many would argue
that a return out of the middle is as ugly as a goto.

Maybe it doesn't matter, and maybe you did actually
improve the code generation, but there's an obvious
way to ditch the warning without changing so much.
Note the semicolon:

out:;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:0.278 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site