lkml.org 
[lkml]   [2002]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.27 devfs
    Marcin Dalecki writes:
    > Kill two inlines which are notwhere used and which don't make sense
    > in the case someone is not compiling devfs at all.

    Rejected. Linus, please don't apply this bogus patch. External patches
    and drivers rely on the inline stubs so that #ifdef CONFIG_DEVFS_FS
    isn't needed.

    Martin, why are you bothering with this kind of false cleanup? These
    inline stubs don't take up any space in the object files, so why
    bother? Also, given that the stubs were carefully added in the first
    place, it suggests that there is a good reason for their presence.

    Why didn't you stop and think it through before firing off a patch, or
    at least ask me if you couldn't see why? This "patch first, think/ask
    questions later" approach is disturbing.

    Regards,

    Richard....
    Permanent: rgooch@atnf.csiro.au
    Current: rgooch@ras.ucalgary.ca
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:0.021 / U:0.616 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site