lkml.org 
[lkml]   [2002]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [CHECKER] 56 potential lock/unlock bugs in 2.5.8
    Hi,

    On Thu, 11 Jul 2002, Andreas Dilger wrote:
    > So, how does adding braces and a linefeed fix the locking problem here?
    > ;-)

    I did add the contents, they were just not added physically. I have them
    somewhere in my mind...

    Index: fs/hpfs/dir.c
    ===================================================================
    RCS file: /var/cvs/thunder-2.5/fs/hpfs/dir.c,v
    retrieving revision 1.1
    diff -p -u -r1.1 dir.c
    --- fs/hpfs/dir.c 19 Jun 2002 02:11:50 -0000 1.1
    +++ fs/hpfs/dir.c 11 Jul 2002 23:44:58 -0000 mind
    @@ -211,7 +211,10 @@ struct dentry *hpfs_lookup(struct inode

    lock_kernel();
    if ((err = hpfs_chk_name((char *)name, &len))) {
    - if (err == -ENAMETOOLONG) return ERR_PTR(-ENAMETOOLONG);
    + if (err == -ENAMETOOLONG) {
    + unlock_kernel();
    + return ERR_PTR(-ENAMETOOLONG);
    + }
    goto end_add;
    }

    Regards,
    Thunder
    --
    (Use http://www.ebb.org/ungeek if you can't decode)
    ------BEGIN GEEK CODE BLOCK------
    Version: 3.12
    GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
    N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
    e++++ h* r--- y-
    ------END GEEK CODE BLOCK------

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:27    [W:0.026 / U:30.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site