lkml.org 
[lkml]   [2002]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CRASH] in tulip driver?
Jussi Laako wrote:
>
> ...
> >
> > --- 2.4.19-pre6/drivers/char/random.c~low-latency Fri Apr 5 12:11:17 2002
> > +++ 2.4.19-pre6-akpm/drivers/char/random.c Fri Apr 5 12:11:17 2002
> > @@ -1369,6 +1369,11 @@ static ssize_t extract_entropy(struct en
> > buf += i;
> > ret += i;
> > add_timer_randomness(&extract_timer_state, nbytes);
> > +#if LOWLATENCY_NEEDED
> > + /* This can happen in softirq's, but that's what we want */
> > + if (conditional_schedule_needed())
> > + break;
> > +#endif
> > }
> >
> > /* Wipe data just returned from memory */
> >
> > So it's a bit of a mystery. It seems to think that it has
> > EXTRACT_ENTROPY_USER.
>
> Whoops, thanks, I found the bug. My fault...
>
> That "break;" breaks some (apparently broken) programs that don't expect
> read of /dev/urandom to return early. For security resons (to get
> identical behaviour compared to the original kernel) I made a fix that
> someone proposed. That fix is apparently broken on some rare situations
> which seem to be difficult to trigger (requires high overall irq rates
> with network load). Now I'm going to remove that part completely and see
> what happens next...
>

Yes, just delete that chunk. I took it out of the ll patch a few
weeks ago because of the /dev/urandom thing.

The random driver only causes a 1-2 milliseocnd blip @500MHz anyway.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site