This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Thu May 2 01:31:05 2024 Received: from spaans.ds9a.nl (adsl-xs4all.ds9a.nl [213.84.159.51]) by kylie.puddingonline.com (8.11.6/8.11.6) with SMTP id g8ILg2X07218 for ; Wed, 18 Sep 2002 23:42:02 +0200 Received: (qmail 22051 invoked from network); 18 Sep 2002 08:19:00 -0000 Received: from unknown (HELO spaans.ds9a.nl) (3ffe:8280:10:360:202:44ff:fe2a:a1dd) by mayo.ipv6.ds9a.nl with SMTP; 18 Sep 2002 08:19:00 -0000 Received: (qmail 4727 invoked by uid 1000); 17 Sep 2002 21:33:01 -0000 Received: (maildatabase); juh Received: (qmail 15966 invoked by alias); 7 Jun 2002 10:02:21 -0000 Received: (qmail 15882 invoked from network); 7 Jun 2002 10:02:21 -0000 Received: from unknown (HELO dipsaus.ds9a.tudelft.nl) (3ffe:8280:10:360:2a0:cff:fe14:9dde) by spaans.ipv6.ds9a.nl with SMTP; 7 Jun 2002 10:02:21 -0000 Received: (qmail 26103 invoked from network); 7 Jun 2002 10:02:20 -0000 Received: from unknown (HELO vger.kernel.org) (::ffff:209.116.70.75) by adsl-xs4all.ds9a.nl with SMTP; 7 Jun 2002 10:02:20 -0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 7 Jun 2002 05:59:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 7 Jun 2002 05:59:18 -0400 Received: from hermes4.atos-group.com ([160.92.18.11]:43527 "EHLO hermes4.atos-group.com") by vger.kernel.org with ESMTP id ; Fri, 7 Jun 2002 05:59:14 -0400 Received: from PickupDirectory by hermes4.atos-group.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2653.13) id M3M89FXY; Fri, 7 Jun 2002 12:02:21 +0200 Message-Id: <20020607095914Z317262-22021+89@vger.kernel.org> From: To: unlisted-recipients:; (no To-header on input) Date: Fri, 7 Jun 2002 05:59:14 -0400 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) X-Spam-Status: No, hits=3.3 required=6.0 tests=NO_REAL_NAME,TO_MALFORMED,SUBJ_MISSING version=2.20 X-Spam-Level: *** Lines: 83 & id ; Fri, 7 Jun 2002 08:38:00 +0200 Received: from mx3.postwall.mm.fr.atosorigin.com (mx003.axime.com [160.92.18.153]) by hermes8.segin.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2653.13) id MM6SML5B; Thu, 6 Jun 2002 18:46:19 +0200 Received: from vger.kernel.org (vger.kernel.org [209.116.70.75]) by mx3.postwall.mm.fr.atosorigin.com (Postfix) with ESMTP id 779F3180B5 for ; Thu, 6 Jun 2002 18:32:12 +0200 (CEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 6 Jun 2002 12:46:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 6 Jun 2002 12:46:41 -0400 Received: from neon-gw-l3.transmeta.com ([63.209.4.196]:2314 "EHLO neon-gw.transmeta.com") by vger.kernel.org with ESMTP id ; Thu, 6 Jun 2002 12:46:41 -0400 Received: (from root@localhost) by neon-gw.transmeta.com (8.9.3/8.9.3) id JAA17531 for ; Thu, 6 Jun 2002 09:46:39 -0700 Received: from mailhost.transmeta.com(10.1.1.15) by neon-gw.transmeta.com via smap (V2.1) id xma017519; Thu, 6 Jun 02 09:46:28 -0700 Received: from palladium.transmeta.com (palladium.transmeta.com [10.1.1.46]) by deepthought.transmeta.com (8.11.6/8.11.6) with ESMTP id g56GkUj06428 for ; Thu, 6 Jun 2002 09:46:30 -0700 (PDT) Received: (from mail@localhost) by palladium.transmeta.com (8.9.3/8.9.3) id JAA22361 for linux-kernel@vger.kernel.org; Thu, 6 Jun 2002 09:46:30 -0700 X-Authentication-Warning: palladium.transmeta.com: mail set sender to news@transmeta.com using -f To: linux-kernel@vger.kernel.org From: torvalds@transmeta.com (Linus Torvalds) Subject: Re: device model update 2/2 Date: Thu, 6 Jun 2002 16:45:25 +0000 (UTC) Organization: Transmeta Corporation Message-ID: References: X-Trace: palladium.transmeta.com 1023381990 22356 127.0.0.1 (6 Jun 2002 16:46:30 GMT) X-Complaints-To: news@transmeta.com NNTP-Posting-Date: 6 Jun 2002 16:46:30 GMT Cache-Post-Path: palladium.transmeta.com!unknown@penguin.transmeta.com X-Cache: nntpcache 2.4.0b5 (see http://www.nntpcache.org/) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org In article , Patrick Mochel wrote: >- > /* detach from driver */ > if (dev->driver->remove) > dev->driver->remove(dev); > put_driver(dev->driver); >+ >+ lock_device(dev); >+ dev->driver = NULL; >+ unlock_device(dev); Code like the above just basically can _never_ be correct. The locking just doesn't make any sense like that. Real locking looks something like this: lock_device(dev); driver = dev->driver; dev->driver = NULL; unlock_device(dev); if (driver->remove) driver->remove(dev); put_driver(driver); together with some promise that "dev" cannot go away from under us (ie a refcount on "dev" itself). Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/