lkml.org 
[lkml]   [2002]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Announce: Kernel Build for 2.5, release 3.0 is available
    On Wed, Jun 05, 2002 at 08:55:35AM +1000, Keith Owens wrote:
    > On Tue, 4 Jun 2002 11:16:46 +0200,
    > Alex Riesen <Alexander.Riesen@synopsys.com> wrote:
    > >Got this trying to compile 2.5.20 with Debian's gcc 2.95.4.
    > >Why it took the system-wide zlib.h?
    > >In file included from /export/home/riesen-pc0/riesen/compile/v2.5/fs/isofs/compress.c:38:
    > >include/linux/zlib.h:34: zconf.h: No such file or directory
    >
    > In order to do separate source and object correctly, kbuild 2.5
    > enforces the rule that #include "" comes from the local directory,
    > #include <> comes from the include path. include/linux/zlib.h
    > incorrectly does #include "zconf.h" instead of #include <linux/zconf.h>,
    > breaking the rules.
    >
    > This was not detected by common-2.5.20-1 because the nostdinc check was
    > incomplete, common-2.5.20-2 does nostdinc correctly. I avoid changing
    > the source code for kbuild 2.5, instead I workaround these incorrect
    > includes by adding extra_cflags() with FIXME comments to correct the
    > code later. I will do a common-2.5.20-3 to workaround zlib.h, in the
    > meantime try this quick and dirty fix

    Sorry for delay. The patch fixed things, indeed.
    And i personally prefer the way you did it here
    much more to any workarounds.

    > --- 2.5.20-pristine/include/linux/zlib.h Mon Apr 15 05:18:43 2002
    > +++ 2.5.20-kbuild-2.5/include/linux/zlib.h Tue Jun 4 11:03:05 2002
    > @@ -31,7 +31,7 @@
    > #ifndef _ZLIB_H
    > #define _ZLIB_H
    >
    > -#include "zconf.h"
    > +#include <linux/zconf.h>
    >
    > #ifdef __cplusplus
    > extern "C" {
    >
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:26    [W:0.027 / U:147.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site