Messages in this thread | | | Date | Fri, 21 Jun 2002 02:22:31 +0200 | From | Martin Dalecki <> | Subject | Re: [redone PATCH 2.5.22] simple ide-tape/floppy.c cleanup |
| |
Użytkownik Bartlomiej Zolnierkiewicz napisał: > redone without controversial bits... > > generic ATAPI hit #1 against 2.5.22: > > - move generic ATAPI structs from ide/ide-floppy.c > and ide/ide-tape.c to include/atapi.h > (this has a nice side effect of making ide-tape > a bit more endianness aware) > > - remove IDEFLOPPY_MIN/MAX() macros, use generic ones > > - add #ifndef __LINUX_ATAPI_H_ blabla to atapi.h > to prevent including it more than once > > > should apply cleanly to 2.5.23
Hi Bartek. Nice to see that you picked up on the idea of code duplication reduction. I think the solution to the packet comand declarations problesm will be to move them over from cdrom.h to linux/scsi.h and just letting scsi/scsi.h include linux/scsi.h. This should even make distros still linking to kernle headers from /usr/include happy and will achieve the goal of unification.
And I agree with Jens that for pragmatic reasons we should just keep the prefix from cdrom.h - it's there and doesn't hurt but we need one, so why not stick with it? The plain macros from scsi.h are too ambigous anyway.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |