Messages in this thread |  | | | Date | Thu, 20 Jun 2002 16:32:14 +0200 | | From | Nicolas Aspert <> | | Subject | Re: [PATCH] Split up agpgart into per implementation files. |
| |
> Thanks for doing this.. I goofed the Makefile, and it doesn't build > correctly as modules under 2.5. Fixed one is at http://www.codemonkey.org.uk/Makefile > Just drop it into drivers/char/agp/ after applying my patch. > Due to build system differences, I'm not sure if your 2.4 patch also > suffers the same problem..
Not sure about that... the Makefile you supplied was looking like a 2.4 one (and looks correct from what I understand from the Docs). I must say that I used kbuild-2.5 port to 2.4 to build the module (kbuild-2.5 makes the build of a single module really easy), so I did not test the original Makefile (kernel-Makefile guru around while it builds ?).
> Oh, and agp.h has the definition of PFX below code which uses it, > and should be moved around.. >
Damn, you're right. Why the h&*( the compiler did not yell about this one ?? A corrected version can be found at http://ltswww.epfl.ch/~aspert/patches/agpgart-split-2.4.19-pre10-ac2-2.diff.bz2
a+
-- Nicolas Aspert Signal Processing Institute (ITS) Swiss Federal Institute of Technology (EPFL)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |