lkml.org 
[lkml]   [2002]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] v2.5.22 - add wait queue function callback support
    On Mon, Jun 17, 2002 at 10:28:12PM +0200, Dave Jones wrote:
    > On Mon, Jun 17, 2002 at 04:14:34PM -0400, Benjamin LaHaise wrote:
    > > +#define add_wait_queue_cond(q, wait, cond) \
    > > + ({ \
    > > + unsigned long flags; \
    > > + int _raced = 0; \
    > > + wq_write_lock_irqsave(&(q)->lock, flags); \
    >
    > I thought we killed off wq_write_lock_irqsave 1-2 kernels ago ?
    >
    > Dave
    >
    > --
    > | Dave Jones. http://www.codemonkey.org.uk
    > | SuSE Labs
    > -

    Dave,

    It depends on what you mean by killed off. I submitted a patch to Linus back
    at 2.5.3 to clean up the way the completion code called the wait queue
    interface. This interface got added then. You picked up those changes at
    that time (and still have them in your kernel tree) but the changes have
    never made it into Linus' tree.

    So, Linus has never had the code to 'kill' and you've never dropped it
    after picking it up.

    --
    Bob Miller Email: rem@osdl.org
    Open Source Development Lab Phone: 503.626.2455 Ext. 17
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:26    [W:0.025 / U:29.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site