[lkml]   [2002]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] 2.5.21 - list.h cleanup

    On Wed, 12 Jun 2002, Rusty Russell wrote:
    > The only really sane way to implement "CONFIG_SMALL_NO_INLINES" that I
    > can think of is to have headers do

    inlines, when used properly, are _not_ larger than not inlining.

    Quite often, inlining means that much of the code goes away due to
    constants etc (alloc_pages(), for example), while in other cases the code
    itself ends up being smaller because a small function takes up space due
    to clobbering registers, memory, and all the function calling sequence

    This is _very_ much the case with the list.h inlines we're talking about.
    They'd be larger, slower, and the resulting assembly code would be less
    readable if they weren't inlined.

    However, we do have some inlines that are just too large, and have often
    grown up over time. They should not be a CONFIG_SMALL_NO_INLINES thing,
    though, they should just be moved into proper .c file.s

    (There are also inlines that _look_ large, but which just go away when
    attacked by an optimizing compiler. See all the "get_user()" stuff with
    case statements etc)

    None of these ugly header file tricks, please.


    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:26    [W:0.023 / U:7.872 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site