lkml.org 
[lkml]   [2002]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] double flush_page_to_ram
    From
       From: Andrea Arcangeli <andrea@suse.de>
    Date: Thu, 9 May 2002 15:01:46 +0200

    On Thu, May 09, 2002 at 04:56:43AM -0700, David S. Miller wrote:
    > Wrong, consider the case where we do early COW in do_no_page, you miss
    > a flush on the new-new page.

    so you mean we need a flush_page_to_ram also before the
    copy_user_highpage to be sure we copy uptodate contents of the
    pagecache? (possibly mapped writeable elsewhere in the user address
    space?)

    That is correct.

    The fact that this ends up with multiple flushes is one of
    several reasons why Documentation/cachetlb.txt encourages
    ports to move to the newer way to handle this (flush_dcache_page()
    plus bits in {copy,clear}_user_page() to handle the cache issues
    and not using flush_page_to_ram() at all).

    Franks a lot,
    David S. Miller
    davem@redhat.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:0.030 / U:118.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site