Messages in this thread | | | Date | Thu, 09 May 2002 07:16:58 -0700 (PDT) | Subject | Re: [PATCH] double flush_page_to_ram | From | "David S. Miller" <> |
| |
From: Hugh Dickins <hugh@veritas.com> Date: Thu, 9 May 2002 14:50:11 +0100 (BST)
Agreed. It's better to keep flush_page_to_ram out of filemap_nopage (and how many other _nopages that ought at present to have it according to David, but don't). As things stand, it's being done unnecessarily twice on the shared maps: your proposal fixes that.
There are many other cases where flush_page_to_ram overflushes, its deficiencies are known.
This is why I am suggesting "don't touch this in 2.4 and let's kill it off in 2.5" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |