lkml.org 
[lkml]   [2002]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BK PATCH] PCI reorg fix
    On Thu, May 09, 2002 at 11:06:45AM -0700, Patrick Mochel wrote:
    >
    > > As a side note, I don't think that any pci_* function should be able to
    > > be called by non-pci drivers. Is it worth spending the time now in 2.5
    > > to make these two functions not rely on 'struct pci_dev' and fix up all
    > > of the drivers and architectures and documentation to reflect this?
    > > Possible names would be alloc_consistent() and free_consistent()?
    >
    > I would suggest something like:
    >
    > void *
    > dev_alloc_consistent(struct device * dev, size_t size, dma_addr_t * dma_handle);
    >
    > and moving dma_mask to struct device.

    That seems reasonable.

    > To handle differences in arch-specific implementations, we could have a
    > callback that the generic code calls.
    >
    > Implementing the generic code is ~5 minutes work. However, it will break
    > everything. OTOH, it would be the best motivation for modernizing these
    > drivers...

    Eeek, the scsi drivers? They haven't even started moving to the > 2
    years old pci interface yet! :)

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:26    [W:2.374 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site