lkml.org 
[lkml]   [2002]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 1/10] suppress allocation warnings for radix-tree allocations


    The recently-added page allocation failure warning generates a lot of
    noise due to radix-tree node allocation failures. Those messages are
    not interesting.

    But I think the warning is otherwise useful - "I got an allocation
    failure and then it crashed" is better than "it crashed".

    The patch suppresses the message for ratnode allocation failures.



    =====================================

    --- 2.5.13/mm/vmscan.c~radix-tree-warning Sun May 5 13:31:59 2002
    +++ 2.5.13-akpm/mm/vmscan.c Sun May 5 13:31:59 2002
    @@ -58,6 +58,7 @@ swap_out_add_to_swap_cache(struct page *
    int ret;

    current->flags &= ~PF_MEMALLOC;
    + current->flags |= PF_RADIX_TREE;
    ret = add_to_swap_cache(page, entry);
    current->flags = flags;
    return ret;
    --- 2.5.13/mm/page_alloc.c~radix-tree-warning Sun May 5 13:31:59 2002
    +++ 2.5.13-akpm/mm/page_alloc.c Sun May 5 13:32:36 2002
    @@ -396,8 +396,11 @@ rebalance:
    return page;
    }
    nopage:
    - printk("%s: page allocation failure. order:%d, mode:0x%x\n",
    - current->comm, order, gfp_mask);
    + if (!(current->flags & PF_RADIX_TREE)) {
    + printk("%s: page allocation failure."
    + " order:%d, mode:0x%x\n",
    + current->comm, order, gfp_mask);
    + }
    return NULL;
    }

    --- 2.5.13/include/linux/sched.h~radix-tree-warning Sun May 5 13:31:59 2002
    +++ 2.5.13-akpm/include/linux/sched.h Sun May 5 13:32:15 2002
    @@ -371,6 +371,7 @@ do { if (atomic_dec_and_test(&(tsk)->usa
    #define PF_MEMDIE 0x00001000 /* Killed for out-of-memory */
    #define PF_FREE_PAGES 0x00002000 /* per process page freeing */
    #define PF_FLUSHER 0x00004000 /* responsible for disk writeback */
    +#define PF_RADIX_TREE 0x00008000 /* debug: performing radix tree alloc */

    /*
    * Ptrace flags
    -
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:22    [W:0.022 / U:31.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site