Messages in this thread |  | | | Date | Fri, 31 May 2002 22:34:54 +0200 | | From | Andrea Arcangeli <> | | Subject | Re: 2.4.19pre8aa3 |
| |
On Thu, May 16, 2002 at 08:26:26PM +0100, Christoph Hellwig wrote: > On Wed, May 15, 2002 at 11:27:33PM +0200, Andrea Arcangeli wrote: > > o minor bdflush tuning difference to avoid char-writer in bonnie > > to stall and to slowdown too much (can make a difference in real > > life) > > ... > > > Only in 2.4.19pre8aa3: 00_bdflush-tuning-1 > > > > Put the mid watermark at 50% (near the high watermark so we don't stall > > too much). > > As the 2.4.19-pre mainline got your buffer throtteling changes I guess it > has the same issues? Do you think it's worth to submit that patch to Marcelo > even that late in the release cycle?
it is not very important, but of course it could go in too.
> > > Only in 2.4.19pre8aa2: 05_vm_10_read_write_tweaks-1 > > Only in 2.4.19pre8aa3: 05_vm_10_read_write_tweaks-2 > > > > Avoid backing out the flush_page_to_ram in this vm patch, > > the one on the pagecache is still needed before the memcpy > > on the pagecache during the early cow (would be cleaner > > to move it up, if Hugh wants to clean it up that's welcome, > > it will be an orthogonal patch, so far I just avoid to > > change that area in my changes, not high prio to clean it up > > as DaveM side it's more high prio to conver the users of > > flush_page_to_ram API to flush_dcache_page/icache new API during 2.5). > > It seems to me you ignore the comments akpm put in the split patches you > merged :) Not only the comment to this change is superflous now, but also
updated :)
> I'd really like to get an answer to the remaining part of it as Andrew's > comment about that part beeing buggy makes a lot of sense to me..
well, as Andrew said it's a microoptimization, but it's not buggy. It is used to avoid marking a page referenced twice if somebody reads with an userspace buffer granularity smaller than PAGE_SIZE, the same optimization exists in the read side (there it is a bit more of a microoptimization because the writer never activates pages but the readers activates pages without such check).
Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |