Messages in this thread | | | Date | Wed, 29 May 2002 15:38:29 -0500 | From | Eli Carter <> | Subject | Re: Linux 2.5.19 |
| |
Russell King wrote: > The following change appeared in 2.5.19: > > xx- a/drivers/video/cyber2000fb.c Wed May 29 11:43:02 2002 > xx+ b/drivers/video/cyber2000fb.c Wed May 29 11:43:02 2002 > @@ -1729,9 +1729,8 @@ > } > > static struct pci_device_id cyberpro_pci_table[] __devinitdata = { > -// Not yet > -// { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682, > -// PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 }, > + { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682, > + PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 }, > { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2000, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_CYBERPRO_2000 }, > { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2010, > > This is completely wrong - the driver has been tested NOT to work on > the Integraphics 1682. As such, please do uncomment these lines. > > In addition, I'm disappointed that no one forwarded the patch for > maintainer approval PRIOR to submitting it to Linus. > > Linus, I request that you apply the following patch. Thanks. > > --- orig/drivers/video/cyber2000fb.c Mon May 6 16:54:10 2002 > +++ linux/drivers/video/cyber2000fb.c Mon May 13 10:48:13 2002 > @@ -1729,8 +1729,9 @@ > } > > static struct pci_device_id cyberpro_pci_table[] __devinitdata = { > - { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682, > - PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 }, > +// Not yet > +// { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_1682, > +// PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_IGA_1682 }, > { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2000, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, ID_CYBERPRO_2000 }, > { PCI_VENDOR_ID_INTERG, PCI_DEVICE_ID_INTERG_2010, > >
How about s/Not yet/This driver has been tested NOT to work on the Integraphics 1682. Do not enable with out contacting the maintainer./ instead? That might avoid the problem recurring...
Just a thought, ignore if you wish.
Eli --------------------. "If it ain't broke now, Eli Carter \ it will be soon." -- crypto-gram eli.carter(a)inet.com `-------------------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |