Messages in this thread | | | Date | Wed, 22 May 2002 10:31:37 -0700 | From | Tom Rini <> | Subject | Re: [PATCH] 2.5.17 IDE 67 |
| |
On Wed, May 22, 2002 at 06:21:10PM +0200, Martin Dalecki wrote: > Uz.ytkownik Tom Rini napisa?: > >On Wed, May 22, 2002 at 09:19:07AM +0200, Martin Dalecki wrote: > > > > > >>Wed May 22 01:43:54 CEST 2002 ide-clean-67 > >> > >>- Nuke COMMERIAL and similar spurious configuration options... > >> The fact that every single default configuration option contained > >> those bits makes this trivial patch appear rather big. > > > > > >This also nukes CONFIG_DMA_NONPCI. While this probably shouldn't have > >been define_bool'ed to 'n' all of the time, there are cases where this > >seems to be properly used. I know PPC4xx uses it (or will be using it > >once the driver is ready to be submitted) and it looks like cris uses it > >as well. > > No I checked. PPC4xx had no functional code for the case > of CONFIG_DMA_NONPCI. It just looked like it had.
You checked the kernel.org tree, not the PPC tree.
> Look at the patch and see that it is removing the two > nonpci_xxx functions which are nowhere defined!
Because the driver isn't quite ready to be submitted just yet.
> The __CRIS__ behaviour is preserved and BTW. > not pretty as well. > But this can be fixed a bit later...
And when the PPC4xx drivers are ready to be submitted we'll need to add in __powerpc__ tests too. Can't we just keep CONFIG_DMA_NONPCI for now?
-- Tom Rini (TR1265) http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |