Messages in this thread | | | Date | Wed, 22 May 2002 18:36:42 +0200 | From | Martin Dalecki <> | Subject | Re: [PATCH] 2.5.17 /dev/ports |
| |
Uz.ytkownik Russell King napisa?: > On Wed, May 22, 2002 at 06:17:26PM +0200, Martin Dalecki wrote: > >>#include <linux/io.h> >>#include <stdio.h> >>#include <stdlib.h> >> >>int main(char *argv[], int argc) >>{ >> int port = aoit(argv[0]); >> int byte = aoit(argv[1]); >> >> if (port > 0) >> return inb(port); >> else >> outb(port, byte); >> >> >> return 0; >>} > > > Erm: > > 1. not checking number of arguments passed. > 2. thinking argv[0] is the first arg. > 3. wrong test for in/out (port > 0 -> inb, port <= 0 -> outb) > 4. returning the read byte via the program status code. > 5. aoit is an undefined function. > 6. including linux/*.h is fundamentally wrong for any user space > program. > > That's one bug every 2 lines. Should I continue? 8)
Where the *hell* - did I say that the above program was supposed to be ANSI C ?#$@#! It's in my own advanced/object oriented/intuitive/component/virtual machine based mdcki-c-alike-python commercial closed source language I'm developing to provide a replacement base for the next generation of Rudy102 distro configuration utilities if you ask. OK?
BTW.> I'm sure it will bite the pants out of C# in the year 2100 where I have scheduled it for the first public release.
Any questions remaining?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |