lkml.org 
[lkml]   [2002]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.15 IDE 61
    Hi...  Please correct me if I'm wrong but:

    I think this patch is broken wrt serialization of channels on buggy
    chipsets.

    The hwgroup was serialized so that in certain cases, it can contain BOTH
    channels, and thus only one channel is active at a time (e.g. cmd640).
    With this patch, you are now serializing only channels, not hwgroups
    (which makes hwgroup totally redundant, yes?), and I can't see which bit
    of your patch protects the chipsets that need both channels to be
    serialized.

    I think I see where you're going with the cleanup (and this isn't
    unrelated to the conversation about IDE-62) but as it stands, this patch
    will IMHO totally fsck any machines with dodgy chipsets.

    Neil
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:26    [W:0.020 / U:59.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site