![]() | |||||||||||||
Messages in this thread |
On Mon, May 13 2002, Martin Dalecki wrote: > Mon May 13 12:38:11 CEST 2002 ide-clean-62 > > - Add missing locking around ide_do_request in do_ide_request(). This is broken, do_ide_request() is already called with the request lock held. tq_disk run -> generic_unplug_device (grab lock) -> __generic_unplug_device -> do_ide_request(). You just introduced a deadlock. This code would have caused hangs or massive corruption immediately if ide_lock wasn't ready held there. Not to mention instant spin_unlock BUG() triggers in queue_command() -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:26 [from the cache] ©2003-2008 | |||||||||||||