Messages in this thread | | | Date | Fri, 10 May 2002 15:10:04 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] BUG() disassembly tweak |
| |
On Fri, 10 May 2002, Hugh Dickins wrote: > > Could we change the i386 BUG() macro slightly again?
If it wants to be changed, I'd actually personally prefer it to be changed to take an explicit string instead of using the filename/linenr at all.
The filename/linenr one has the size problem (those absolute file names are _long_), and sucks when you have slight kernel version skew and suddenly the information isn't obviously unambiguous at all.
It also sucks for inline functions or other users of BUG that would potentially want to have different output.
In short, I suspect it would be nicer with
kernel BUG: release_task(current)
instead of
kernel BUG at /home/torvalds/v2.5/linux/exit.c:59
(the exact point where the BUG happens _is_ given by the EIP, so in that sense file and linenr are not actually all that useful. A descriptive string would be more readable, and equally useful at pinpointing at a source level).
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |