Messages in this thread | | | Date | Fri, 10 May 2002 15:53:17 -0400 (EDT) | From | Alexander Viro <> | Subject | Re: [PATCH] iget_locked [1/6] |
| |
On Fri, 10 May 2002, Jan Harkes wrote:
> Hi Linus, > > Here is a series of 6 patches that started off as fixing a race in > iget4, but ended up as a merge of the XFS icreate functionality, removal > of the 'reiserfs specific hack' and reduces the VFS dependency on i_ino. > > It has seen some discussion on linux-fsdevel.
I'm pretty much OK with that, but there are some comments on the patches
> + if (set) > + err = set(inode, data); > + if (!err) { > + inodes_stat.nr_inodes++; > + list_add(&inode->i_list, &inode_in_use); > + list_add(&inode->i_hash, head); > + inode->i_state = I_LOCK; > + } > spin_unlock(&inode_lock); > > + if (err) { > + destroy_inode(inode); > + return NULL; > + }
Please, take that code out of the path - will be cleaner that way.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |