lkml.org 
[lkml]   [2002]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86 Boot enhancements, boot protocol 2.04 7/9
From
Date
Tom Rini <trini@kernel.crashing.org> writes:

> On Wed, Apr 03, 2002 at 08:23:58PM -0700, Eric W. Biederman wrote:
> > Tom Rini <trini@kernel.crashing.org> writes:
> >
> > > On Wed, Apr 03, 2002 at 09:41:55AM -0700, Eric W. Biederman wrote:
> > >
> > > > In imitation of the arm and ppc ports a CONFIG_CMDLINE option is also
> > > > implemented.
> > >
> > > Just wondering, why didn't you do it with a
> > > CONFIG_CMDLINE_BOOL/CONFIG_CMDLINE set of options? The way you did it,
> > > I _think_ you can't actually get a help msg from 'config' or
> > > 'oldconfig', you'll just set the commandline to '?'.
> >
> > I just tested it and oldconfig at least works.
>
> That's sort of supprising.

True. But I'm not complaining.

What I find funny is that with menuconfig I can't backspace when
editing the command line.

> The way you're doing it now, you're sticking it into final image itself
> tho, and passing it along. If you're not going to be able to change the
> commandline, why not handle it all in C? eg:
> strcpy(cmd_line, CONFIG_CMDLINE);
> if ( passed a new commandline )
> strcpy(cmd_line, new_cmdline);

I actually put it at a location where you can edit it in the final
image. Which is why I don't do it all in C. I have even documented
this...

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site