lkml.org 
[lkml]   [2002]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: devfs: BKL *not* taken while opening devices
    Russell King wrote:
    > On Mon, Apr 29, 2002 at 06:21:34PM +0100, Arjan van de Ven wrote:
    >
    >>I'm not convinced of that. It's not nearly a critical path and it's
    >>better to get even the "dumb" drivers safe than to risk having big
    >>security holes in there for years to come.
    >
    > Would it be worth dropping a BUG_ON(!kernel_locked()) in tty_open() to
    > catch this type of error? The tty code heavily relies on the BKL.
    >
    > This way, such locking problems would get caught early, since everyone
    > uses the tty code during boot, right?

    I like the idea. But, while we're at it, does anyone have a good enough
    grasp of locking the the TTY layer that we can start peeling some of the
    BKL out of there? Somebody was doing tests over a serial console here
    and the lockmeter data showed horrible BKL contention and hold times.

    --
    Dave Hansen
    haveblue@us.ibm.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:3.475 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site