lkml.org 
[lkml]   [2002]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: devfs: BKL *not* taken while opening devices
    On Mon, Apr 29, 2002 at 06:21:34PM +0100, Arjan van de Ven wrote:
    > I'm not convinced of that. It's not nearly a critical path and it's
    > better to get even the "dumb" drivers safe than to risk having big
    > security holes in there for years to come.

    Would it be worth dropping a BUG_ON(!kernel_locked()) in tty_open() to
    catch this type of error? The tty code heavily relies on the BKL.

    This way, such locking problems would get caught early, since everyone
    uses the tty code during boot, right?

    --
    Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
    http://www.arm.linux.org.uk/personal/aboutme.html

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:3.993 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site