lkml.org 
[lkml]   [2002]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] discontigmem support for ia32 NUMA box against 2.4.19pre7
On Mon, Apr 29, 2002 at 06:15:26PM -0700, Patricia Gaughen wrote:
> + if [ "$CONFIG_MULTIQUAD" = "y" ]; then
> + bool 'Discontiguous Memory Support' CONFIG_DISCONTIGMEM
> + if [ "$CONFIG_DISCONTIGMEM" = "y" ]; then
> + define_bool CONFIG_DISCONTIGMEM_X86 y
> + define_bool CONFIG_IBMNUMAQ y
> + define_bool CONFIG_NUMA y
> + fi
> + fi

CML code uses three tab indentes. Also the way you do the config looks
rather strange. I'd rather ask for IBM NUMAQ support and imply NUMA &
DISCONTIGMEM support if set. Also CONFIG_DISCONTIGMEM_X86 looks like
an ugly workaround to me, all places where it is used should rather check
for one of CONFIG_DISCONTIGMEM/CONFIG_NUMA/CONFIG_IBMNUMAQ.
(and CONFIG_IBMNUMAQ would better be named CONFIG_X86_NUMAQ, IMHO).

> +
> +#ifdef CONFIG_SMP
> + /*
> + * But first pinch a few for the stack/trampoline stuff
> + * FIXME: Don't need the extra page at 4K, but need to fix
> + * trampoline before removing it. (see the GDT stuff)
> + */
> + reserve_bootmem_node(NODE_DATA(0), PAGE_SIZE, PAGE_SIZE);
> +#endif

Umm, NUMA without SMP looks rather strange to me..

> +#ifdef CONFIG_X86_LOCAL_APIC
> + /*
> + * Find and reserve possible boot-time SMP configuration:
> + */
> + find_smp_config();
> +#endif

Dito for local APIC.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [W:0.080 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site