[lkml]   [2002]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH} SMBIOS support
On Sat, Apr 27, 2002 at 09:45:10AM -0500, Corey Minyard wrote:
> >Any reason for initialising it there instead of using a subsys_initcall
> >from smbios.c ?
> Can you control other orders within the subsystem?

Use different types of _initcall. See include/linux/init.h

> Other things that come later in this subsystem might need it
> Actually, it might be needed before this, I've moved it to before the PCI
> initialization,
> since this contains interrupt information and possible PCI information.

Ok, I overlooked the relationship of PCI to SMBIOS.
As pci is initialised with subsys_initcall, you could initialise
earlier by using core_initcall.

> > > + char str[80];
> >Worth adding a if (len>80) return here in case of crap biosen?
> >Or am I overly paranoid?
> It's printing 16 hex characters every time, so it doesn't matter. And
> it's only debug code, anyway.



| Dave Jones.
| SuSE Labs
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:25    [from the cache]
©2003-2011 Jasper Spaans