Messages in this thread | | | Date | Fri, 26 Apr 2002 13:57:18 +0200 | From | Andrea Arcangeli <> | Subject | Re: get_pid fixes against 2.4.19pre7 |
| |
On Fri, Apr 26, 2002 at 12:53:47PM +0100, Russell King wrote: > On Fri, Apr 26, 2002 at 01:44:09PM +0200, Andrea Arcangeli wrote: > > + set_bit(p->pid, pid_bitmap); > > + set_bit(p->pgrp, pid_bitmap); > > + set_bit(p->tgid, pid_bitmap); > > + set_bit(p->session, pid_bitmap); > > Since we're running under a lock, do we really need the guaranteed > atomic (and therefore expensive) set_bit(), or would __set_bit() > suffice?
__set_bit definitely suffices, thanks.
Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |