Messages in this thread | | | Date | Wed, 24 Apr 2002 10:51:28 -0700 (PDT) | Subject | Re: bug in sch_generic.c:pfifo_fast_enqueue | From | "David S. Miller" <> |
| |
From: Patrick McHardy <kaber@trash.net> Date: Thu, 11 Apr 2002 15:56:35 +0200
"David S. Miller" schrieb: > From: Patrick McHardy <kaber@trash.net> > Date: Mon, 1 Apr 2002 21:43:03 +0200 (CEST) > > I found a small bug in pfifo_fast_enqueue, instead of > > if (list->qlen <= skb->dev->tx_queue_len) > it should be > if (list->qlen <= qdisc->dev->tx_queue_len) > > skb->dev == qdisc->dev should be invariant when this > code runs. So the code is correct, albeit possibly > confusing.
Although in normal circumstances the assumption may be right it fails in this case. It would be nice if you apply my patch as it doesn't changes anything and enforces correct behaviour in cases like mine.
Ok, for the sake of consistency, I've made the change. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |