Messages in this thread | | | Date | Mon, 22 Apr 2002 17:39:59 +0100 | From | Christoph Hellwig <> | Subject | Re: [RFC] patch to /proc/meminfo to display NUMA stats |
| |
On Mon, Apr 22, 2002 at 10:05:19AM -0700, Martin J. Bligh wrote: > Below is a patch to /proc/meminfo to display free, used and total > memory per node on a NUMA machine. It works fine on an ia32 > machine, but is not yet ready for submission until I make it generic. > Before I go to the effort of doing that, I thought I'd seek some feedback. > > Comments?
Sure. First I wonder whether it would be possible to kill nr_free_pages() and nr_free_highpages() (or infact all of the nr_free*page() functions) in favour of the per-node ones, externalizing the for loop. Or if there are to many users at least make them use the per-node version. Second I wonder whether nr_free_pages_node() and nr_free_highpages_node() should take a pgdat instead of a node id as the caller has it around anyway.
Also I think the per-node info should be in /proc/meminfo even for UMA machines, it doesn't hurt but makes it more consistant. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |