lkml.org 
[lkml]   [2002]   [Apr]   [22]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 22 Apr 2002 13:34:14 +0200
FromFrancois Romieu <>
SubjectRe: HDLC driver for MPC860-based hardware
Greetings,

- please, please, please read Documentation/CodingStyle
- kmalloc can fail
- cache seems to be disabled (?) for pages you memcpy later -> why ?
- if register_hdlc_device() fails for some device, the succeeded one are
  deallocated but not unregistered
- alloc_mem() doesn't deallocate on failure
- goto may help handling failure

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 12:25    [W:0.079 / U:0.020 seconds]
©2003-2008 Jasper Spaans