Messages in this thread | | | Date | Sat, 20 Apr 2002 12:47:53 -0700 | From | "Martin J. Bligh" <> | Subject | Re: [PATCH] Documenation/vm/numa |
| |
> + node_start_paddr The starting physical address of the node. This doesn't > + work really well as an unsigned long as it breaks for > + ia32 with PAE for example. A more suitable solution would be > + to record this as a Page Frame Number (pfn). This could be > + trivially defined as (page_phys_addr >> PAGE\_SHIFT).
This looks fine.
> + Alternatively, it could be the struct page * index inside > + mem_map.
But I'd just omit this last sentence ... that only works for machines with a contig mem_map (not NUMA), and it's kind of an accidental kludge that happens to work in some cases, not the proper definition (what I originally posted was confusing).
I actually submitted a patch a couple of days ago to fix these to a pfn instead. If that gets in, we can update the documentation then.
M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |