lkml.org 
[lkml]   [2002]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.8 IDE 36
    Vojtech Pavlik wrote:
    > On Tue, Apr 16, 2002 at 09:05:21AM +0200, Martin Dalecki wrote:
    >
    >>Tue Apr 16 01:02:47 CEST 2002 ide-clean-36
    >>
    >>- Consolidate ide_choose_drive() and choose_drive() in to one function.
    >>
    >>- Remove sector data byteswpapping support. Byte-swapping the data is supported
    >> on the file-system level where applicable. Byte-swapped interfaces are
    >> supported on a lower level anyway. And finally it was used inconsistently.
    >
    >
    > Are you sure about this? I think file systems support LE/BE, but not
    > byteswapping because of IDE being LE on a BE system.

    I'm sure about this. For the following reasons:

    1. The removed functionality affected only sector data transfers.

    2. The following code for interfaces with byte swapped BUS setups
    still remains intact:

    #if defined(CONFIG_ATARI) || defined(CONFIG_Q40)
    if (MACH_IS_ATARI || MACH_IS_Q40) {
    /* Atari has a byte-swapped IDE interface */
    insw_swapw(IDE_DATA_REG, buffer, bytecount / 2);
    return;
    }
    #endif

    And indeed as you show - there was confusion about this issue
    throughout the whole driver, since the taskfile_in(out)
    functions where basically just the byteswapped variants and
    where not uses consistently.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:2.149 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site