lkml.org 
[lkml]   [2002]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [Patch] Compilation error on 2.5.8
From
Date
On Tue, 2002-04-16 at 01:24, Robert Love wrote:
> On Mon, 2002-04-15 at 19:34, Bongani wrote:
>
> > Does this also look cleaner ?
>
> > -static inline void setup_per_cpu_areas(void)
> > -{
> > -}
> > +
> > +#define setup_per_cpu_areas() do { } while(0)
> > +
>
> Personally yes, but others would disagree.
>
> In fact, if we use a define setup_per_cpu_areas can not be used outside
> of this compilation unit. Right now this looks to be the case, but if
> something other than init/main.c wanted to use setup_per_cpu_areas we
> would need to make the code an actual function or put the define in a
> header file.
>
> Since either case should optimize away, maybe we should make it a static
> inline in both cases, since that is the authors original preference ...
>
> Robert Love
>

Ok, so this patch should be fine then

--- init/main.c Tue Apr 16 06:52:20 2002
+++ init/main.c_new Tue Apr 16 06:55:17 2002
@@ -272,6 +272,10 @@
#define smp_init() do { } while (0)
#endif

+static inline void setup_per_cpu_areas(void)
+{
+}
+
#else

#ifdef __GENERIC_PER_CPU
@@ -297,9 +301,11 @@
}
}
#else
+
static inline void setup_per_cpu_areas(void)
{
}
+
#endif /* !__GENERIC_PER_CPU */

/* Called by boot processor to activate the rest. */



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [W:0.046 / U:9.704 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site