Messages in this thread | | | Date | Thu, 11 Apr 2002 10:29:50 -0400 (EDT) | From | Alexander Viro <> | Subject | Re: 2.5.8-pre3 & ext3: cannot chown |
| |
On Thu, 11 Apr 2002, Andrew Morton wrote:
> Duncan Sands wrote: > > > > The subject just about says it all. After 12 hours > > of uptime running 2.5.8-pre3 on an ext3 partition, > > I noticed that changing the owner of a file had no > > effect. Rebooting with 2.4.18, there was no problem > > in using chown. > > How does this look? > > --- linux-2.5.8-pre3/fs/open.c Tue Apr 9 18:16:40 2002 > +++ 25/fs/open.c Thu Apr 11 00:15:09 2002 > @@ -524,11 +524,11 @@ static int chown_common(struct dentry * > goto out; > newattrs.ia_valid = ATTR_CTIME; > if (user != (uid_t) -1) { > - newattrs.ia_valid = ATTR_UID; > + newattrs.ia_valid |= ATTR_UID; > newattrs.ia_uid = user; > } > if (group != (gid_t) -1) { > - newattrs.ia_valid = ATTR_GID; > + newattrs.ia_valid |= ATTR_GID;
Good catch. Linus, please apply.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |