Messages in this thread | | | Date | Thu, 11 Apr 2002 00:09:37 +0100 | Subject | Re: [PATCH] Radeon frame buffer driver | From | Peter Horton <> |
| |
On Wed, Apr 10, 2002 at 01:06:09PM +0200, Geert Uytterhoeven wrote: > On Wed, 10 Apr 2002, Peter Horton wrote: > > On Wed, Apr 10, 2002 at 11:57:31AM +0100, benh@kernel.crashing.org wrote: > > > > > > Fine, though I noticed the get_cmap_len got changed to > > > + return var->bits_per_pixel == 8 ? 256 : 16; > > > > > > > The colour map is only used by the kernel and the kernel only uses 16 > > entries so there isn't any reason to waste memory by making it any > > larger. I checked a few other drivers and they do the same (aty128fb for > > one). > > However, this change will make the driver not save/restore all color map > entries on VC switch in graphics mode. >
My error. Apologies. I was getting confused between the colour map with the console colour <-> pixel value mapping (pointed to by ->dispsw_data) - too many variables with similiar names :-(
P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |