Messages in this thread | | | From | Ed Vance <> | Subject | RE: [PATCH] serial.c procfs kudzu - discussion | Date | Fri, 8 Mar 2002 10:12:30 -0800 |
| |
On Fri Mar 08, 2002, Russell King wrote: > > I think there are two bugs here that need treating in different ways. > > 1. Not displaying port statistics for iomem-based ports. This is > probably an oversight when iomem ports were added to the serial > driver. > > 2. "port:" entry being 0. I don't think we really want to report IO > port or memory addresses here without giving userspace some > indication which we're reporting. > > For 2, I'd suggest replacing "port:" with "mem:" for iomem ports, and > changing the serinfo: line to reflect the changed format (this is > probably ignored by kudzu though.) > > Does this sound reasonable?
Hi Russell,
Yes. I'll change the serinfo line rev marking from 1.0 to 1.1 and label the iomem value as "mem". If I remember correctly, kudzu detects that field by its delimiters, so it does not matter that we change the field label. It's probably easiest for me to verify by just trying it. If there is a surprise there, I will inform Bill Nottingham at Red Hat.
Also, I'll verify that the port statistics flow unit runs for the iomem case.
Thanks, Ed Vance - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |