Messages in this thread | | | From | Hubertus Franke <> | Subject | Re: [PATCH] Futexes IV (Fast Lightweight Userspace Semaphores) | Date | Tue, 5 Mar 2002 18:16:57 -0500 |
| |
On Tuesday 05 March 2002 05:39 pm, Davide Libenzi wrote: > On Tue, 5 Mar 2002, Rusty Russell wrote: > > + pos_in_page = ((unsigned long)uaddr) % PAGE_SIZE; > > + > > + /* Must be "naturally" aligned, and not on page boundary. */ > > + if ((pos_in_page % __alignof__(atomic_t)) != 0 > > + || pos_in_page + sizeof(atomic_t) > PAGE_SIZE) > > + return -EINVAL; > > How can this : > > (pos_in_page % __alignof__(atomic_t)) != 0 > > to be false, and together this : > > pos_in_page + sizeof(atomic_t) > PAGE_SIZE > > to be true ? > This is enough : > > if ((pos_in_page % __alignof__(atomic_t)) != 0) > >
I believe not all machine have alignof == sizeof > > > - Davide > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- -- Hubertus Franke (frankeh@watson.ibm.com) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |