Messages in this thread | | | Date | Sat, 30 Mar 2002 21:40:06 +0500 | From | Denis Zaitsev <> | Subject | Re: [PATCH] matroxfb_base.c - not a so little patch |
| |
On Fri, Mar 22, 2002 at 01:17:04PM +0100, Petr Vandrovec wrote: > On 22 Mar 02 at 16:47, Denis Zaitsev wrote: > > > > The patch is against 2.5.5. It seems that matroxfb_base.c is still > > the same since that time. And I assume matroxfb_base.c with > > <if (var->bits_per_pixel == 4)> branch present, i.e. without my > > previous little fix. > > Did you verified effects on generated code/data size? > > > + for (p= &table[0].bpp; *p < bpp; p+= sizeof table[0]); > > + var->red .offset= *++p; var->red .length= *++p; > > + var->green .offset= *++p; var->green .length= *++p; > > + var->blue .offset= *++p; var->blue .length= *++p; > > + var->transp.offset= *++p; var->transp.length= *++p; > > Please no. Access fields by their names, and do not assume anything > about padding. > Petr Vandrovec > vandrove@vc.cvut.cz >
I'm sorry, Petr, why don't you answer anything to me? I'd sent the cured patch a week ago... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |