lkml.org 
[lkml]   [2002]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Linux-ATM-General] Re: [PATCH] Updated ATM patch for 2.4.19-pre4

>Comments welcome.
Looks ok to me.

> static inline struct br2684_dev *BRPRIV(const struct net_device *net_dev)
> {
>- return (struct br2684_dev *) ((char *) (net_dev) -
>- (unsigned long) (&((struct br2684_dev *) 0)->net_dev));
>+ return list_entry(net_dev, struct br2684_dev, net_dev);
> }
Although list_entry does the same thing it's inappropriate here. People
will be confused.

Max

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [W:0.065 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site