Messages in this thread | | | Date | Mon, 25 Mar 2002 13:53:39 -0800 | From | Maksim Krasnyanskiy <> | Subject | Re: [Linux-ATM-General] Re: [PATCH] Updated ATM patch for 2.4.19-pre4 |
| |
>Comments welcome. Looks ok to me.
> static inline struct br2684_dev *BRPRIV(const struct net_device *net_dev) > { >- return (struct br2684_dev *) ((char *) (net_dev) - >- (unsigned long) (&((struct br2684_dev *) 0)->net_dev)); >+ return list_entry(net_dev, struct br2684_dev, net_dev); > } Although list_entry does the same thing it's inappropriate here. People will be confused.
Max
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |