Messages in this thread | | | Date | Mon, 25 Mar 2002 23:01:14 +0000 | From | "Stephen C. Tweedie" <> | Subject | Re: [Ext2-devel] [patch] speed up ext3 synchronous mounts |
| |
Hi,
On Sun, Mar 24, 2002 at 01:50:16PM -0800, Andrew Morton wrote:
> Again, we don't need to sync indirects as we dirty them because > we run a commit if IS_SYNC(inode) prior to returning to the > caller of write(2). > > Writing a 10 meg file in 0.1 meg chunks is sped up by, err, > a factor of fifty. That's a best case. > > --- linux-2.4.18-pre8/fs/ext3/inode.c Tue Feb 5 00:33:05 2002 > +++ linux-akpm/fs/ext3/inode.c Wed Feb 6 23:40:48 2002 > @@ -581,8 +581,6 @@ static int ext3_alloc_branch(handle_t *h > > parent = nr; > } > - if (IS_SYNC(inode)) > - handle->h_sync = 1; > } > if (n == num) > return 0;
OK. This was just a relic of ages back when we had an overarching transaction spanning multiple writepages in ext3_file_write(). In that case, setting that transaction to be synchronous multiple times was no extra cost. Doing it just once at the end should be fine.
Cheers, Stephen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |