Messages in this thread | | | Date | Mon, 25 Mar 2002 15:58:07 -0500 | From | christophe barbé <> | Subject | Re: [PATCH] 3c59x and resume |
| |
On Mon, Mar 25, 2002 at 11:11:27AM -0800, Greg KH wrote: > > Could you point me to a specific usb driver ? > > In the drivers/usb directory, the following are network drivers: > CDCEther.c > catc.c > kaweth.c > pegasus.c > usbnet.c
$ grep MODULE_PARM CDCEther.c catc.c kaweth.c pegasus.c usbnet.c CDCEther.c:MODULE_PARM (multicast_filter_limit, "i"); CDCEther.c:MODULE_PARM_DESC (multicast_filter_limit, "CDCEther maximum number of filtered multicast addresses"); pegasus.c:MODULE_PARM(loopback, "i"); pegasus.c:MODULE_PARM(mii_mode, "i"); pegasus.c:MODULE_PARM_DESC(loopback, "Enable MAC loopback mode (bit 0)"); pegasus.c:MODULE_PARM_DESC(mii_mode, "Enable HomePNA mode (bit 0),default=MII mode = 0");
Note that this is exactly what I think. Each option is defined with a unique value used for all devices.
/usr/src/linux/drivers/usb$ grep MODULE_PARM ../net/3c59x.c MODULE_PARM(debug, "i"); ... MODULE_PARM(enable_wol, "1-" __MODULE_STRING(8) "i"); MODULE_PARM(rx_copybreak, "i"); ...
In a sense the vortex is more flexible. Most options are defined by a single value but for a few you can pass a vector. NOTE that the 8 limit is only in the MODULE_PARM lines.
But this flexibility is no more adapted.
$ man nameif ... DESCRIPTION nameif renames network interfaces based on mac addresses. When no arguments are given /etc/mactab is read. Each line
nameif solved a problem but not during the device activation (this is the difference between rename and name). Would not it be possible to add to hotplug a way to give back some advices to the kernel.
kernel -> hotplug : I am going to insert this device. hotplug -> kernel : ok but use this options optionA,optionB,...
You can then still use nameif during the register phase or eventually pass a directive earlier to avoid possible races.
Christophe
-- Christophe Barbé <christophe.barbe@ufies.org> GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8 F67A 8F45 2F1E D72C B41E
L'experience, c'est une connerie par jour mais jamais la même. [unhandled content-type:application/pgp-signature] | |