Messages in this thread | | | Date | Sat, 23 Mar 2002 22:10:58 +0100 | From | Francois Romieu <> | Subject | Re: [PATCH] Updated ATM patch for 2.4.19-pre4 |
| |
Maksim Krasnyanskiy <maxk@qualcomm.com> : [...] > I updated ATM patch for 2.4.19-pre4. It includes couple of fixes that I > missed in my first patch > and includes ATM Ethernet bridging support (RFC2684) implemented by Marcell > GAL. > It is rather big for email. Here is the URL: > http://bluez.sourceforge.net/patches/atm.patch-2.4.19-pre4.gz
1 - It won't compile with CONFIG_ATM_BR2684_IPFILTER=y (see error message below). Suggested fix: ed net/atm/br2684.c <<EOF 17a #include <linux/ip.h> . wq EOF
-> Error message: make[2]: Entering directory `/tmp/romieu/kernel/linux-2.4.19-pre4/net/atm' kgcc -D__KERNEL__ -I/tmp/romieu/kernel/linux-2.4.19-pre4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -march=i686 -DMODULE -DKBUILD_BASENAME=br2684 -c -o br2684.o br2684.c br2684.c: In function `packet_fails_filter': br2684.c:378: dereferencing pointer to incomplete type make[2]: *** [br2684.o] Error 1 make[2]: Leaving directory `/tmp/romieu/kernel/linux-2.4.19-pre4/net/atm' make[1]: *** [_modsubdir_atm] Error 2 make[1]: Leaving directory `/tmp/romieu/kernel/linux-2.4.19-pre4/net' make: *** [_mod_net] Error 2
2 - As the patch does many things, splitting it in parts would be nice imho.
3 - I have on my TODO a 'please ifconfig down before killing br2684ctl' BUG that Marcell Gal told me a few months ago (*spleen*). Did someone take care of it ?
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |