lkml.org 
[lkml]   [2002]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Scalable CPU bitmasks
Date
On 18 March 2002 20:07, Russ Weight wrote:
> While systems with more than 32 processors are still
> out in the future, these interfaces provide a path for gradual
> code migration. One of the primary goals is to provide current
> functionality without affecting performance.

Not so far in the future. "7.52 second kernel compile" thread is about
timing kernel compile on the 32 CPU SMP box.

I don't know whether BUG() in inlines makes them too big, but
_for() _loops_ in inline functions definitely do that.
Here's one of the overgrown inlines:

> +static inline char *cpumap_format(cpumap_t map, char *buf, int size)
> +{
> + if (size < CPUMAP_BUFSIZE) {
> + BUG();
> + }
> +
> +#if CPUMAP_SIZE > 1
> + sprintf(buf, "0x" CPUMAP_FORMAT_STR, map[CPUMAP_SIZE-1]);
> + {
> + int i;
> + char *p = buf + strlen(buf);
> + for (i = CPUMAP_SIZE-2; i >= 0; i--, p += (sizeof(long) + 1)) {
> + sprintf(p, " " CPUMAP_FORMAT_STR, map[i]);
> + }
> + }
> +#else
> + sprintf(buf, "0x" CPUMAP_FORMAT_STR, map[0]);
> +#endif
> + return(buf);
> +}
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site