[lkml]   [2002]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: 2.4.19pre3aa2
    On Fri, Mar 15 2002, Jari Ruusu wrote:
    > - No more illegal sleeping in generic_make_request().

    I've told you this before -- sleeping in make_request is not illegal,
    heck it happens _all the time_. Safely sleeping requires a reserved pool
    of the units you wish to allocate, of course. In fact I think that would
    be much nicer than the path you are following here by delaying
    allocations to the loop thread (and still not using a reserved pool).

    Briefly looking through the patch.

    - loop_put_buffer(), it looks racy to check waitqueue_active there.

    - if(!bh) return((struct buffer_head *)0);


    - Also, please adher to the style. VaRiAbLe names can hurt the eyes, and
    stuff like

    if (something) break;


    etc don't belong too. Could you fix that up?

    That said, thanks for fixing it!

    Jens Axboe

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:25    [W:0.021 / U:17.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site