lkml.org 
[lkml]   [2002]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.4.19-pre3
On Tue, Mar 12 2002, Karsten Weiss wrote:
> > Here goes -pre3, with the new IDE code. It has been stable enough time in

Oh good god, the nr_sectors/current_nr_sectors for the pio data phases
haven't been fixed _yet_?!

task_in_intr()
{
...
pBuf = rq->buffer + ((rq->nr_sectors - rq->current_nr_sectors) * SECTOR_SIZE);
}

And that's just one instance. Good luck running 2.4.19-pre3, this is
just so badly broken I can't find words to explain it (again). It's
really puzzling why this is still broken. I fixed it in 2.5 when the
merge happened there, the issue has been known for at least that long. I
can only recommend that no one uses 2.4.19-pre3!

Marcelo, at least apply the noop patch here. If I get motivated I'll fix
the interrupt handlers as well, can't say I really want to though...

--- drivers/ide/Config.in~ Tue Mar 12 14:22:01 2002
+++ drivers/ide/Config.in Tue Mar 12 14:22:17 2002
@@ -159,8 +159,6 @@
bool ' UMC-8672 support' CONFIG_BLK_DEV_UMC8672
fi
fi
-
- bool ' Use the NOOP Elevator (WARNING)' CONFIG_BLK_DEV_ELEVATOR_NOOP
else
bool 'Old hard disk (MFM/RLL/IDE) driver' CONFIG_BLK_DEV_HD_ONLY
define_bool CONFIG_BLK_DEV_HD $CONFIG_BLK_DEV_HD_ONLY
--- drivers/ide/ide-probe.c~ Tue Mar 12 14:22:06 2002
+++ drivers/ide/ide-probe.c Tue Mar 12 14:22:23 2002
@@ -606,12 +606,6 @@

q->queuedata = HWGROUP(drive);
blk_init_queue(q, do_ide_request);
-
- if (drive->media == ide_disk) {
-#ifdef CONFIG_BLK_DEV_ELEVATOR_NOOP
- elevator_init(&q->elevator, ELEVATOR_NOOP);
-#endif
- }
}

/*

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.230 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site