lkml.org 
[lkml]   [2002]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.5] BUG check in elevator.c:237
Jens Axboe wrote:

> That's nonsense too. I added the expiry hook to let lower levels decide
> what should happen when an interrupt timeout occurs. So there's been
> _no_ interrupt if we enter this from the timer handler.

No interrupt from the same drive right.

>>And plase guess whot? CD-ROM is the only driver which is using
>>this facility. Please have a look at the last
>>
>
> Right, it was added to handle long commands like format unit etc.

Hmm seeks on tapes can take awfully long as well...

>>argument of ide_set_handler(). The second argument is the
>>interrutp handler for a command. The third is supposed to be
>>the poll timerout function. But if you look at the
>>actual poll function found in ide-cd.c (and only there).
>>You may as well feel to try to just execute its commands directly in
>>ide_timer_expiry, thus reducing tons of possible races ind the
>>overall intr handling found currently there.
>>
>
> I don't know what tangent you are going off on here, I think you should
> re-read this code a lot more carefully. There's no polling going on
> here.

I think the term polling used by me is the only problem here ;-).
(I consider every command controll which goes without irq notification
just polling... whatever it polls once or not ;-).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.071 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site